Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer: replace VAULT_HOST with AWS_ROLE_ARN #6118

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

jjacobelli
Copy link
Contributor

This PR is replacing the VAULT_HOST variable with AWS_ROLE_ARN. This is required to use the new token service to get AWS credentials.

Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 21, 2024
@jjacobelli jjacobelli self-assigned this Oct 21, 2024
@jjacobelli jjacobelli marked this pull request as ready for review October 22, 2024 13:19
@jjacobelli jjacobelli requested a review from a team as a code owner October 22, 2024 13:19
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look like sccache is working here:

  Compile requests                    322
  Compile requests executed           322
  Cache hits                          317

(build link)

But I don't understand these changes. Is there a write-up about them I could read?

For example, how is this working when there wasn't a corresponding change in https://github.com/rapidsai/devcontainers/commits/branch-24.12/?

Features in these devcontainers explicitly expect to use vault, I thought: https://github.com/rapidsai/devcontainers/blob/a5bba51e0c21e71e90f8b4c63e96a3c3d2dcdd53/USAGE.md?plain=1#L40

@jjacobelli
Copy link
Contributor Author

But I don't understand these changes. Is there a write-up about them I could read?

I don't think there is an issue that I can link here, but we are working on removing our Vault instance to use our new token service to get AWS credentials instead

For example, how is this working when there wasn't a corresponding change in https://github.com/rapidsai/devcontainers/commits/branch-24.12/?

Features in these devcontainers explicitly expect to use vault, I thought: https://github.com/rapidsai/devcontainers/blob/a5bba51e0c21e71e90f8b4c63e96a3c3d2dcdd53/USAGE.md?plain=1#L40

Changes on devcontainers are done in this PR: rapidsai/devcontainers#392

@bdice
Copy link
Contributor

bdice commented Oct 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit a5e35c5 into rapidsai:branch-24.12 Oct 25, 2024
50 checks passed
@jjacobelli jjacobelli deleted the devcontainers-vault branch October 25, 2024 18:36
@jameslamb
Copy link
Member

Ah I see, thanks for the links @jjacobelli (here and the others you sent me privately). Changes make sense to me with that additional context. And thanks @trxcllnt and @bdice for helping with approvals while I was out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants