Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type from pickle header for CumlArray #6120

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Remove type from pickle header for CumlArray #6120

merged 1 commit into from
Oct 25, 2024

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Oct 22, 2024

Including the type in the header is unnecessary for (de)serialization

@wphicks wphicks requested a review from a team as a code owner October 22, 2024 20:33
@wphicks wphicks requested review from cjnolet and divyegala October 22, 2024 20:33
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 22, 2024
@wphicks wphicks added bug Something isn't working non-breaking Non-breaking change labels Oct 24, 2024
@dantegd
Copy link
Member

dantegd commented Oct 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit addccbd into rapidsai:branch-24.12 Oct 25, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@cjnolet cjnolet Awaiting requested review from cjnolet cjnolet is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cuml-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wphicks @dantegd