Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle missing categorical data in experimental FIL #6132

Merged

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Nov 7, 2024

Correctly handle missing categorical data in FIL when 0 is one of the included categories.

Resolve #5578.

@wphicks wphicks added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Nov 7, 2024
@wphicks wphicks requested review from a team as code owners November 7, 2024 23:45
@github-actions github-actions bot added Cython / Python Cython or Python issue CUDA/C++ labels Nov 7, 2024
@hcho3
Copy link
Contributor

hcho3 commented Nov 8, 2024

Thanks for the fix!

@wphicks
Copy link
Contributor Author

wphicks commented Nov 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit 22c3ee8 into rapidsai:branch-24.12 Nov 8, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CUDA/C++ Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect NaN handling in experimental FIL with categorical splits
3 participants