Remap BATCH_TREE_REORG to TREE_REORG in FIL #6161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid a bug which causes a batch of trees in the BATCH_TREE_REORG implementation to be labeled as complete (all having reached leaf nodes) when they are not. In the best case, this causes a crash when invalid shared memory is accessed. In the worst case, trees will silently contribute incorrect values to the final output. This workaround simply disables BATCH_TREE_REORG by remapping BATCH_TREE_REORG to TREE_REORG in the C++ layer. The fundamental issue should be fixed through promotion of experimental FIL to default.
github-actions
bot
added
conda
wphicks
added
bug
wphicks
requested review from
raydouglass,
cjnolet,
viclafargue and
divyegala
github-actions
bot
added
conda
dantegd
approved these changes
Dec 19, 2024
|
/merge |
|
/merge |
jakirkham
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a bug which causes a batch of trees in the BATCH_TREE_REORG implementation to be labeled as complete (all having reached leaf nodes) when they are not. In the best case, this causes a crash when invalid shared memory is accessed. In the worst case, trees will silently contribute incorrect values to the final output.
This workaround simply disables BATCH_TREE_REORG by remapping BATCH_TREE_REORG to TREE_REORG in the C++ layer. The fundamental issue should be fixed through promotion of experimental FIL to default.