Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSL error. #6177

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix SSL error. #6177

merged 1 commit into from
Dec 11, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 11, 2024

Last night, wheel-tests-cuml / 11.8.0, 3.10, arm64, rockylinux8, a100, latest-driver, oldest-deps failed.

The failure occurred in testing/dask/utils.py's load_text_corpus:

cuml/python/cuml/cuml/testing/dask/utils.py

Line 12 in 052cdde

def load_text_corpus(client):

The errors looked like:

FAILED test_dask_naive_bayes.py::test_basic_fit_predict - urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1007)>
FAILED test_dask_naive_bayes.py::test_single_distributed_exact_results - urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1007)>
FAILED test_dask_naive_bayes.py::test_score - urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1007)>

This adopts some fixes from rapidsai/cugraph#4825 that will hopefully help with SSL certificate failures.

@bdice bdice requested review from a team as code owners December 11, 2024 14:59
@bdice bdice self-assigned this Dec 11, 2024
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Dec 11, 2024
@bdice bdice added bug Something isn't working non-breaking Non-breaking change and removed conda conda issue Cython / Python Cython or Python issue labels Dec 11, 2024
@bdice
Copy link
Contributor Author

bdice commented Dec 11, 2024

This PR can target 24.12 or 25.02, it is based on 24.12 and has no conflicts.

jameslamb
jameslamb approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, think this is a good fix.

@bdice bdice changed the base branch from branch-25.02 to branch-24.12 December 11, 2024 15:31
@raydouglass raydouglass merged commit 6dfc61b into rapidsai:branch-24.12 Dec 11, 2024
67 of 69 checks passed
@bdice bdice mentioned this pull request Dec 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@jameslamb jameslamb jameslamb approved these changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/packaging-codeowners

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cuml-python-codeowners

Assignees

@bdice bdice

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @dantegd @jameslamb @raydouglass