Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated thrust features and replace with libcu++ ones #6248

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Jan 23, 2025

CCCL is deprecating a lot of legacy thrust features, so replace them with the standard ones from libc++ or just drop them altogether

@miscco miscco requested a review from a team as a code owner January 23, 2025 14:49
@miscco miscco requested review from wphicks and divyegala January 23, 2025 14:49
@miscco miscco force-pushed the drop_deprecated_thrust branch 2 times, most recently from e5a0f26 to 887a20f Compare January 23, 2025 18:10
@miscco miscco requested a review from a team as a code owner January 23, 2025 18:10
@github-actions github-actions bot added the CMake label Jan 23, 2025
@miscco miscco force-pushed the drop_deprecated_thrust branch from 887a20f to fe287ca Compare January 23, 2025 18:34
@github-actions github-actions bot removed the CMake label Jan 23, 2025
@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 23, 2025
@miscco
Copy link
Contributor Author

miscco commented Jan 24, 2025

@dantegd Couly you please restart CI, it seems connection issues failed some runs

@dantegd
Copy link
Member

dantegd commented Jan 26, 2025

@miscco to solve the devcontainer jobs we need to merge branch-24.02 into the PR. There seems to be a small conflict in rf_test.cu, any chance you could resolve it and merge 24.02 into the PR?

@miscco
Copy link
Contributor Author

miscco commented Jan 27, 2025

@dantegd I pulled 25.02 and merged it in I assume that is what you meant with 24.02?

@dantegd
Copy link
Member

dantegd commented Jan 27, 2025

/merge

@rapids-bot rapids-bot bot merged commit 66abfc5 into rapidsai:branch-25.02 Jan 27, 2025
70 checks passed
@miscco miscco deleted the drop_deprecated_thrust branch January 28, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants