Log UMAP arrays at trace verbosity level. #6274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
csadorf
force-pushed
the
fix/decrease-umap-logging-verbosity
branch
from
6cccf26 to
d7efec6
Compare
|
|
cjnolet
reviewed
Jan 29, 2025
| if (ML::default_logger().should_log(ML::level_enum::debug)) { | ||
| CUML_LOG_DEBUG("Compute Membership Strength"); | ||
| if (ML::default_logger().should_log(ML::level_enum::trace)) { | ||
| CUML_LOG_TRACE("Compute Membership Strength"); |
There was a problem hiding this comment.
I think we should keep these at DEBUG level but put any actual arrays at trace level.
There was a problem hiding this comment.
Addressed in c6b6e36 .
dantegd
approved these changes
Feb 10, 2025
|
/merge |
csadorf
force-pushed
the
fix/decrease-umap-logging-verbosity
branch
from
d7af773 to
16f79b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.02 #6274 +/- ##
================================================
- Coverage 68.24% 67.07% -1.18%
================================================
Files 202 202
Lines 13079 13069 -10
================================================
- Hits 8926 8766 -160
- Misses 4153 4303 +150 ☔ View full report in Codecov by Sentry. |
|
@dantegd I think this PR might need an admin merge. |
wphicks
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the UMAP logging verbosity. Avoids printing potentially large arrays.