Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify-codeowners hook #6275

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Add verify-codeowners hook #6275

merged 4 commits into from
Feb 20, 2025

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner January 29, 2025 16:47
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 29, 2025
@KyleFromNVIDIA KyleFromNVIDIA requested a review from vyasr January 29, 2025 16:58
@jameslamb jameslamb removed the request for review from msarahan February 7, 2025 18:37
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners February 19, 2025 18:41
@KyleFromNVIDIA KyleFromNVIDIA requested a review from bdice February 19, 2025 18:41
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ ci labels Feb 19, 2025
@KyleFromNVIDIA KyleFromNVIDIA changed the base branch from branch-25.02 to branch-25.04 February 19, 2025 18:41
jameslamb
jameslamb approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving. I've also removed all the unnecessary codeowners review requests left behind by changing the base branch.

@jameslamb jameslamb removed request for a team February 19, 2025 18:44
@github-actions github-actions bot removed conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ labels Feb 20, 2025
@github-actions github-actions bot removed the ci label Feb 20, 2025
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 71bc290 into rapidsai:branch-25.04 Feb 20, 2025
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@vyasr vyasr Awaiting requested review from vyasr

@bdice bdice Awaiting requested review from bdice bdice was automatically assigned from rapidsai/cuml-cmake-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleFromNVIDIA @jameslamb