Copy attributes from the original class to the proxy #6306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the proxy look and feel more like the original class.
csadorf
added
improvement
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the proxy look and feel more like the original class.
This copies several attributes, not just
__name__and makes sure the signature of the constructor looks like that of the scikit-learn class. This is useful for people who inspect it during coding (like some editors) oripython'sLogisticRegression?.For some reason the test intest_basic_estimator.pyfails because the proxy doesn't have a__name__attribute. Trying to work out why, if someone can spot the mistake let me knowThis is an alternative/extended version of #6305