Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue caused by None arg provided by sklearn pipeline #6326

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Fix issue caused by None arg provided by sklearn pipeline #6326

merged 4 commits into from
Feb 20, 2025

Conversation

viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Feb 17, 2025 •
edited
Loading

No description provided.

@viclafargue viclafargue requested a review from a team as a code owner February 17, 2025 10:51
@viclafargue viclafargue requested review from cjnolet and bdice February 17, 2025 10:51
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 17, 2025
@betatim
Copy link
Member

betatim commented Feb 17, 2025

Can you add a test that fails without this PR and passes with it? That way we can stop this bug from coming back

@csadorf csadorf added bug Something isn't working non-breaking Non-breaking change labels Feb 18, 2025
csadorf
csadorf approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny suggestions, otherwise LGTM. Thanks a lot!

betatim
betatim approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test.

LGTM (modulo Simon's comments)

@dantegd dantegd mentioned this pull request Feb 20, 2025
Draft
21 tasks
@csadorf
Copy link
Contributor

csadorf commented Feb 20, 2025

/merge

@rapids-bot rapids-bot bot merged commit 2ebe78b into rapidsai:branch-25.04 Feb 20, 2025
67 of 68 checks passed
dantegd added a commit to dantegd/cuml that referenced this pull request Feb 21, 2025
@dantegd
Backport PR rapidsai#6326
94c2881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csadorf csadorf csadorf approved these changes

@betatim betatim betatim approved these changes

@cjnolet cjnolet Awaiting requested review from cjnolet cjnolet is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cuml-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working cuml-cpu Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viclafargue @betatim @csadorf @dantegd