Make KernelRidge inherit from UniversalBase #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for 0cc
betatim
added
improvement
csadorf
approved these changes
Feb 18, 2025
viclafargue
requested changes
Feb 19, 2025
| @@ -247,6 +255,7 @@ class KernelRidge(Base, RegressorMixin): | |||
| filter_params=True, **params) | |||
|
|
|||
| @generate_docstring() | |||
| @enable_device_interop | |||
| def fit(self, X, y, sample_weight=None, | |||
There was a problem hiding this comment.
Also, small detail, but it is always nice to use the self.n_features_in_ attribute instead of local variable n_rows when ingesting data. This gives one more thing to replicate sklearn's behavior.
There was a problem hiding this comment.
You mean we should set self.n_features_in_ instead of using a local variable? Can do that. One question, n_features_in_ is the number of features, so shouldn't it be set to n_cols instead?
There was a problem hiding this comment.
You're right meant the number of columns.
viclafargue
approved these changes
Feb 20, 2025
|
/merge |
dantegd
added a commit
to dantegd/cuml
that referenced
this pull request
Feb 20, 2025
21 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 23, 2025
Previously this wasn't handled correctly, but was _sometimes_ masked by `GridSearchCV` in the old test fixing things behind the scenes. This fixes the bug, adds a test that doesn't require the accelerator, and changes the accelerator test to be both simpler (matching the smoketests in the rest of the file) and much faster (the `GridSearchCV` in the test made the test quite slow on my machine). Fixup to the fix applied in #6327. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #6354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for zero code change acceleration. With the accelerator turned on, the scikit-learn example
./examples/miscellaneous/plot_kernel_ridge_regression.pyfails because it returns a cupy array fromThis fixes this.