[REVIEW] Adjusted Rand Index implementation #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
venkywonka
commented
Jun 4, 2019
venkywonka
commented
- CUDA implementation of the adjusted rand index metric
- gtests for the same
- wrapper for exposing to the cuML API
added 5 commits
June 4, 2019 03:16
- implemented CUDA header that calculates the adjusted rand index between two clusterings - implemented the gtests for the same
- modifying the dOxygen comments - minor changes to formatting and comments
- reduced a redundant parameter that the adjusted-rand-index function implementation takes as input - wrote a wrapper to expose this module to cuml API - Merged remote-tracking branch 'upstream/branch-0.8' into fea-ext-adjusted-rand-index-implementation
teju85
requested changes
Jun 4, 2019
cjnolet
changed the title
- changed the wrapper parameter types of y and y-hat from double to int since they represent nominal/ordinal data - added `prims/add_sub_dev_scalar.cu` to CMakeLists.txt
|
I will take a look over this PR tomorrow.
…On Fri, Jun 7, 2019 at 12:49 AM Thejaswi Rao ***@***.***> wrote:
***@***.**** approved this pull request.
Changes LGTM.
@dantegd <https://github.com/dantegd> @cjnolet
<https://github.com/cjnolet> please merge
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#652?email_source=notifications&email_token=AAJPKYHKFWIEJWCALPE3FFTPZHSEBA5CNFSM4HS3NIX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB23ZSLI#pullrequestreview-246913325>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJPKYHODPNX6XUDEPJFSKDPZHSEBANCNFSM4HS3NIXQ>
.
|
added 3 commits
June 6, 2019 22:16
- refactored the types starting from the wrapper function to it's traces in further functions
|
Were you able to review this @cjnolet ? |
cjnolet
requested changes
Jun 14, 2019
|
|
||
| //workspace allocation | ||
| char* pWorkspace = nullptr; | ||
| size_t workspaceSz = MLCommon::Metrics::getCMatrixWorkspaceSize( |
There was a problem hiding this comment.
Let's use a more descriptive name since this function is sharing the namespace with everything else under metrics.
cjnolet
changed the title
cjnolet
added
3 - Ready for Review
- changed the 'getCMatrixWorkspaceSize' method in contingencyMatrix.h and all it's other occurrances to 'getContingencyMatrixWorkspaceSize'.
cjnolet
approved these changes
Jun 18, 2019
added 2 commits
June 17, 2019 21:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.