Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all non-multi feature combinations #1062

Closed
Tracked by #1046
thomcom opened this issue Apr 10, 2023 · 0 comments · Fixed by #1064
Closed
Tracked by #1046

Test all non-multi feature combinations #1062

thomcom opened this issue Apr 10, 2023 · 0 comments · Fixed by #1064
Assignees
Labels
2 - In Progress Currenty a work in progress feature request New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Milestone

Comments

@thomcom
Copy link
Contributor

thomcom commented Apr 10, 2023

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Critical (currently preventing usage)

Please provide a clear description of problem you would like to solve.

I'm rewriting the test dispatcher to produce more verifiable and specific results. The first iteration of the test dispatcher only produces tests for non-multi variants of geometries. It tests a hand-built selection of feature primitives that cover what appear to be every relationship that can exist between two simple features.

I say appear to be because of the analysis in https://github.com/thomcom/spatial-predicates that demonstrates that for all Polygon/Polygon (no inner ring) relationships, there are only six unique DE-9IM relates categories. For all Polygon/Polygon (with inner ring) relationships, there are only 8.

This issue tracks my progress for writing a test dispatch system that not only covers all non-multiple geometry types and their possible combinations, but more important returns correct results for them.

Describe any alternatives you have considered

No response

Additional context

No response

@thomcom thomcom added feature request New feature or request Needs Triage Need team to review and classify labels Apr 10, 2023
@thomcom thomcom self-assigned this Apr 10, 2023
@thomcom thomcom added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Needs Triage Need team to review and classify labels Apr 10, 2023
@thomcom thomcom moved this from Todo to In Progress in cuSpatial Apr 10, 2023
@thomcom thomcom added this to the DE-9IM milestone Apr 10, 2023
@thomcom thomcom moved this from In Progress to Review in cuSpatial Apr 28, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currenty a work in progress feature request New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant