Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic predicates need point interfaces #1068

Closed
thomcom opened this issue Apr 12, 2023 · 1 comment
Closed

Basic predicates need point interfaces #1068

thomcom opened this issue Apr 12, 2023 · 1 comment
Assignees
Labels
2 - In Progress Currenty a work in progress feature request New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Comments

@thomcom
Copy link
Contributor

thomcom commented Apr 12, 2023

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Critical (currently preventing usage)

Please provide a clear description of problem you would like to solve.

Point-in-polygon is a point interface. It's basic API is to take in a list of geometries and a list of points, and returns a list of booleans w.r.t the condition is satisfied.

Equals and intersection need the same API, so that results can be merged back into their original geometry shapes based on their point predicates.

I need to build wrappers around the basic predicates such that they return a list of booleans.

linestring.intersects(linestrings) returns a list of offsets, geometries, and original indices for each intersection found in the relationship. I need to wrap is such that it provides a basic interface linestrings.intersects(points) that returns True or False for each point in the rhs.

pairwise_multipoint_equals_count returns a list of counts for the number of times that a multipoint point in the rhs appears in the lhs. This needs to be wrapped such that I can call multipoints.equals(points) which returns a True/False for each point in the rhs that is contained in the lhs.

This feature is required because the discrete math rules for building features are point-wise rules. Consider for contains, given a point that is not contained in a polygon, that point is not inside the polygon unless it also intersects the polygon boundary.

@thomcom thomcom added feature request New feature or request Needs Triage Need team to review and classify labels Apr 12, 2023
@thomcom thomcom self-assigned this Apr 12, 2023
@thomcom thomcom added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Needs Triage Need team to review and classify labels Apr 12, 2023
@thomcom thomcom moved this from Todo to In Progress in cuSpatial Apr 12, 2023
@thomcom thomcom moved this from In Progress to Review in cuSpatial Apr 13, 2023
@thomcom thomcom moved this from Review to Done in cuSpatial Apr 13, 2023
@thomcom
Copy link
Contributor Author

thomcom commented Apr 13, 2023

I have written these wrappers as a part of (#1062)

@thomcom thomcom closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currenty a work in progress feature request New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

No branches or pull requests

1 participant