Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "experimental" headers into main cuspatial include directory #1083

Closed
Tracked by #663
harrism opened this issue Apr 19, 2023 · 0 comments · Fixed by #1081
Closed
Tracked by #663

Move "experimental" headers into main cuspatial include directory #1083

harrism opened this issue Apr 19, 2023 · 0 comments · Fixed by #1081
Assignees
@harrism
Labels
improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library

Comments

@harrism
Copy link
Member

harrism commented Apr 19, 2023 •
edited
Loading

First step in #663: move the now non-experimental header-only API headers into the main include/cuspatial directory. As mentioned in #663, since header-only API files are all .cuh there should be no name conflicts.

In a followup we can make naming and organization more consistent and consolidate common API headers (e.g. all *_bounding_boxes() APIs in a single header instead of 3.
@harrism harrism mentioned this issue Apr 19, 2023
Closed
@harrism harrism self-assigned this Apr 19, 2023
@harrism harrism added libcuspatial Relates to the cuSpatial C++ library improvement Improvement / enhancement to an existing function labels Apr 19, 2023
@harrism harrism moved this from Todo to In Progress in cuSpatial Apr 19, 2023
@harrism harrism mentioned this issue Apr 19, 2023
Merged
3 tasks
@harrism harrism moved this from In Progress to Review in cuSpatial Apr 19, 2023
rapids-bot bot pushed a commit that referenced this issue Apr 26, 2023
@harrism
Move experimental headers into main include/cuspatial directory (#…
5f91e68 
…1081)

Fixes #1083.

* Consolidates all headers into `include/cuspatial/`. This works without conflicts because header-only API headers have the `.cuh` extension while column-based API headers have the `.cpp` extension.
* Consolidates and reorganizes tests. Header-only and column-based tests are stored together.
* Updates documentation to remove references to `experimental` and also renames the `REFACTORING_GUIDE.md` to `HEADER_ONLY_API_GUIDE.md` and updates it.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Michael Wang (https://github.com/isVoid)

URL: #1081
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrism harrism

Labels
improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move experimental headers into main include/cuspatial directory harrism/cuspatial
1 participant
@harrism