Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP always passes because it never matches any points #1380

Closed
trxcllnt opened this issue May 2, 2024 · 0 comments · Fixed by #1346
Closed

[BUG]: JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP always passes because it never matches any points #1380

trxcllnt opened this issue May 2, 2024 · 0 comments · Fixed by #1346
Labels
bug Something isn't working

Comments

@trxcllnt
Copy link
Contributor

trxcllnt commented May 2, 2024 •
edited
Loading

Version

22.06

On which installation method(s) does this occur?

No response

Describe the issue

The spatial join in the JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP test isn't matching any points because the points are distributed exactly along a diagonal that doesn't intersect with the test bounding boxes.

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response
@trxcllnt trxcllnt added the bug Something isn't working label May 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in cuSpatial May 2, 2024
@trxcllnt trxcllnt mentioned this issue May 2, 2024
Merged
3 tasks
@rapids-bot rapids-bot bot closed this as completed in #1346 May 6, 2024
rapids-bot bot pushed a commit that referenced this issue May 6, 2024
@trxcllnt
Fix JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP test (#1346)
0324a33 
The `JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP` test isn't returning any points because they aren't evenly distributed.

The first commit adds a check to ensure the test fails when no results are returned. The second commit fixes the `JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP` test.

Fixes #1380.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1346
@github-project-automation github-project-automation bot moved this from Todo to Done in cuSpatial May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP test trxcllnt/cuspatial
1 participant
@trxcllnt