Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] linestring device code uses std::min when it should use min() #745

Closed
3 tasks done
harrism opened this issue Oct 20, 2022 · 0 comments · Fixed by #755
Closed
3 tasks done

[BUG] linestring device code uses std::min when it should use min() #745

harrism opened this issue Oct 20, 2022 · 0 comments · Fixed by #755
Assignees
@isVoid
Labels
bug Something isn't working

Comments

@harrism
Copy link
Member

harrism commented Oct 20, 2022 •
edited by isVoid
Loading

std::min does not map to the GPU hardware min() function. This should be changed.

point_linestring_distance.cuh
linestring_distance.cuh
linestring.cuh

#745 (comment)
@harrism harrism added the bug Something isn't working label Oct 20, 2022
@harrism harrism added the c++ label Oct 20, 2022
@harrism harrism moved this to Todo in cuSpatial Oct 20, 2022
@isVoid isVoid mentioned this issue Nov 1, 2022
Merged
3 tasks
@isVoid isVoid moved this from Todo to Review in cuSpatial Nov 1, 2022
@rapids-bot rapids-bot bot closed this as completed in #755 Nov 7, 2022
rapids-bot bot pushed a commit that referenced this issue Nov 7, 2022
@isVoid
Refactor of pairwise_linestring_distance to use `multilinestring_ra…
870f103 
…nge`, adds support to multilinestring distance (#755)

Note, this is the first part of `pairwise_linestring_distance` refactoring, part 1 of PR: #753

Depends on #752 

Contributes to #706, #703

Closes #745

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Mark Harris (https://github.com/harrism)

URL: #755
Repository owner moved this from Review to Done in cuSpatial Nov 7, 2022
@harrism harrism removed the c++ label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isVoid isVoid

Labels
bug Something isn't working
Projects
cuSpatial
Status: Done
Milestone
No milestone
2 participants
@harrism @isVoid