use make_device_vector in pairwise_point_in_polygon_test #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwharris
added
improvement
isVoid
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Welcome back @cwharris ! And thanks for the contribution! This PR is ready to go, there's a follow up to the PR where we can refactor pairwise_point_in_polygon to accept a multipoint_range and ``multipolygon_range`. Would you like to try that?
|
Nice to see you dude! |
|
/merge |
|
@isVoid what is the issue number for the |
|
Sorry about the delay! The refactor is tracked by: #703. It's best if cuSpatial can use a homogenous input pattern with multi*_range. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use make_device_vector in pairwise_point_in_polygon_test
closes #825
Checklist