Add CUDA major to cuspatial's build/string
#1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python packages had the same `build/string` for CUDA 11 & 12 builds, which resulted in only one of these builds being uploaded (appears to be CUDA 11 since those builds were a bit faster). To distinguish these and ensure both CUDA 11 & 12 packages are uploaded, add the CUDA major version to the `build/string`.
3 tasks
thomcom
approved these changes
Jul 6, 2023
AjayThorve
reviewed
Jul 6, 2023
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
raydouglass
approved these changes
Jul 7, 2023
AjayThorve
approved these changes
Jul 7, 2023
thomcom
approved these changes
Jul 7, 2023
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python packages had the same
build/stringfor CUDA 11 & 12 builds, which resulted in only one of these builds being uploaded (appears to be CUDA 11 since those builds were a bit faster). To distinguish these and ensure both CUDA 11 & 12 packages are uploaded, add the CUDA major version to thebuild/string.Description
Checklist