Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark GeoSeries.distance #1242

Closed
wants to merge 79 commits into from
Closed

Benchmark GeoSeries.distance #1242

wants to merge 79 commits into from

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Jul 31, 2023 •
edited
Loading

Description

closes #994
There are primitive benchmark results for GeoSeries.distance in #1231. This PR plans to add more benchmark coverage:
TODO:

  • point-point
  • point-linestring
  • point-polygon
  • linestring-linestring
  • linestring-polygon
  • polygon-polygon
  • Geometry complexity dimension
  • Geometry spatial relationship dimension
  • Write the blog

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

raydouglass and others added 30 commits February 4, 2020 14:06
@raydouglass
Merge pull request rapidsai#118 from rapidsai/branch-0.12
5672d5a 
[RELEASE] cuspatial v0.12
@GPUtester
REL v0.12.0 release
ce35d17
@raydouglass
Update CHANGELOG.md
bcc7561
@raydouglass
Merge pull request rapidsai#152 from rapidsai/branch-0.13
128eed9 
[RELEASE] cuspatial v0.13
@GPUtester
REL v0.13.0 release
12ee694
@raydouglass
Merge pull request rapidsai#230 from rapidsai/branch-0.14
d3c5a00
@GPUtester
REL v0.14.0 release
f6847fa
@ajschmidt8
update master references
86e41dd
@mike-wendt
REL DOC Updates for main branch switch
46e67c9 
[skip ci] Update master references for main branch
@raydouglass
Merge pull request rapidsai#276 from rapidsai/branch-0.15
1628b97 
[RELEASE] cuspatial v0.15
@GPUtester
REL v0.15.0 release
274275a
@raydouglass
Merge pull request rapidsai#282 from rapidsai/branch-0.15
a3d6f3d 
[RELEASE] Re-release v0.15 [skip-ci]
@GPUtester
REL v0.15.0 release
c5b7527
@raydouglass
Update CHANGELOG.md
c337b32
@raydouglass
Merge pull request rapidsai#311 from rapidsai/branch-0.16
2d7e7d7 
[RELEASE] cuspatial v0.16
@GPUtester
REL v0.16.0 release
096f468
@raydouglass
Update CHANGELOG.md
9aeebc8
@ajschmidt8
Merge pull request rapidsai#330 from rapidsai/branch-0.17
eb3096c
@GPUtester
REL v0.17.0 release
897b304
@raydouglass
Merge pull request rapidsai#360 from rapidsai/branch-0.18
c4ff738
@GPUtester
REL v0.18.0 release
f4da460
@raydouglass
Merge pull request rapidsai#380 from rapidsai/branch-0.19
45e7b87 
[RELEASE] cuspatial v0.19
@GPUtester
REL v0.19.0 release
df1d93c
@raydouglass
Merge pull request rapidsai#409 from rapidsai/branch-21.06
b5e0810
@GPUtester
REL v21.06.00 release
37798cd
@ajschmidt8
Merge pull request rapidsai#417 from rapidsai/branch-21.06
4ed3e98 
REL Fix `21.06` Release Changelog
@raydouglass
Merge pull request rapidsai#439 from rapidsai/branch-21.08
5119e15 
[RELEASE] cuspatial v21.08
@GPUtester
REL v21.08.00 release
b8590f9
@raydouglass
Merge pull request rapidsai#442 from rapidsai/branch-21.08
c4f0725 
[RELEASE] v21.08.01 cuspatial
@GPUtester
REL v21.08.01 release
7c0151b
isVoid and others added 12 commits August 7, 2023 08:30
@isVoid
Update benchmarking config
9c09c99
@isVoid
Add numba polygon generator
8da018a
@isVoid
Merge branch 'branch-23.10' of https://github.com/rapidsai/cuspatial …
63c0a31 
…into feature/distance_benchmark
@isVoid
[skip ci]update polygon generator to add centroid randomness
326b499
@isVoid
Reuse polygon generator for linestring generator to add linestring lo…
5b89064 
…cality
@isVoid
update polygon generator with radius parameter, update linestring dis…
61ae461 
…tance API with complexity control
@raydouglass
Merge pull request rapidsai#1252 from rapidsai/branch-23.08
216c68b 
[RELEASE] cuspatial v23.08
@raydouglass
REL v23.08.00 release
d8a31ee
@raydouglass
Merge pull request rapidsai#1256 from rapidsai/branch-23.08
150a566 
[HOTFIX] v23.08.01
@raydouglass
REL v23.08.01 release
2660aba
@isVoid
Merge branch 'branch-23.10' of https://github.com/rapidsai/cuspatial …
54e87d9 
…into feature/distance_benchmark
@isVoid
Merge branch 'main' of https://github.com/rapidsai/cuspatial into fea…
e371e89 
…ture/distance_benchmark
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 28, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@isVoid
Copy link
Contributor Author

isVoid commented Sep 28, 2023

/ok to test

@isVoid isVoid added benchmarks Related to benchmarks non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 28, 2023
@isVoid isVoid marked this pull request as ready for review September 28, 2023 08:59
@isVoid isVoid requested a review from a team as a code owner September 28, 2023 08:59
@isVoid isVoid requested review from thomcom and harrism September 28, 2023 08:59
harrism
harrism approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for completing this!

@isVoid
Copy link
Contributor Author

isVoid commented Oct 3, 2023

Any idea why CI isn't run on this PR?

@harrism
Copy link
Member

harrism commented Oct 3, 2023

The commit history doesn't look very clean. It has some unverified commits. You could try rebasing on 23.10 head?

@isVoid
Copy link
Contributor Author

isVoid commented Oct 4, 2023

/ok to test

isVoid added a commit to isVoid/cuspatial that referenced this pull request Oct 5, 2023
@isVoid
Migration from rapidsai#1242
ce8b4c0
@isVoid
Copy link
Contributor Author

isVoid commented Oct 5, 2023

Supersedes by #1277

@isVoid isVoid closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
benchmarks Related to benchmarks improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Benchmark ST_Distance
6 participants
@isVoid @harrism @raydouglass @GPUtester @ajschmidt8 @mike-wendt