Use branch-23.12 workflows. #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
non-breaking
AyodeAwe
approved these changes
Oct 11, 2023
|
/merge |
|
@bdice looks like there is an |
|
@harrism I fixed the remaining 23.10 references on the 23.12 branch (not related to this PR as far as I could see). We'll need a Python codeowner review to merge. |
bdice
commented
Oct 12, 2023
| @@ -113,7 +113,7 @@ An example command from the Release Selector: | |||
| docker run --gpus all --pull always --rm -it \ | |||
| --shm-size=1g --ulimit memlock=-1 --ulimit stack=67108864 \ | |||
| -p 8888:8888 -p 8787:8787 -p 8786:8786 \ | |||
| nvcr.io/nvidia/rapidsai/notebooks:23.120-cuda11.8-py3.10 | |||
| nvcr.io/nvidia/rapidsai/notebooks:23.12-cuda11.8-py3.10 | |||
There was a problem hiding this comment.
The update-version.sh regex for the README had an error, which I fixed.
bdice
commented
Oct 12, 2023
| @@ -26,7 +26,7 @@ requires = [ | |||
|
|
|||
| [project] | |||
| name = "cuproj" | |||
| version = "23.12.0" | |||
| version = "23.12.00" | |||
There was a problem hiding this comment.
Aligning with other RAPIDS projects -- these lines are supposed to be "full versions" and not "PEP 440 versions." I'm not sure how this typo occurred, because the update-version.sh script is set to do this correctly as far as I can tell.
harrism
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches back to using
branch-23.12for CI workflows because the CUDA 12 ARM conda migration is complete.