Use cuda::proclaim_return_type on device lambdas. #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
bdice
force-pushed
the
cccl-2.2.0-support
branch
from
c704e99 to
ebddd5f
Compare
26 tasks
harrism
approved these changes
Dec 13, 2023
|
Looks like some device_vector ctor problems. |
bdice
force-pushed
the
cccl-2.2.0-support
branch
from
f39e05c to
7226804
Compare
The changes I pulled in were originally targeting CCCL 2 -- this branch can only use the |
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
This PR updates cuspatial to CCCL 2.2.0. Do not merge until all of RAPIDS is ready to update. Follow-up to #1314. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Ray Douglass (https://github.com/raydouglass) - Robert Maynard (https://github.com/robertmaynard) - Mark Harris (https://github.com/harrism) URL: #1315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes cuspatial compatible with Thrust 2 by adding
cuda::proclaim_return_type, but does not upgrade the version of Thrust/CCCL just yet. Currently we use libcudacxx 2.1.0, which makescuda::proclaim_return_typeavailable, but we still use Thrust 1.17.2 which doesn't require device lambdas to have proclaimed return types. This diff is separated out from #1096. I will create a separate PR which contains only packaging changes / version updates for the CCCL 2 migration. This PR is nonbreaking, while the second PR will be breaking.Checklist