Unskip taxi notebook from CI #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
approved these changes
Jul 31, 2024
3 tasks
isVoid
approved these changes
Aug 1, 2024
jameslamb
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Thanks for doing this! Looking through the logs, I see that this nyc_taxi_years_correlation.ipynb notebook ran successfully in 28 seconds 🎉
I do see another issue in those logs... looks like the ZipCodes_Stops_PiP_cuSpatial.ipynb notebook is broken:
TypeError Traceback (most recent call last)
File /tmp/tmp.q8TobhA9hO/ZipCodes_Stops_PiP_cuSpatial-test.py:302
299 zipcode_quadtree.set_polygon(d_states, poly_column='geometry')
301 # Join state and zip code boundaries
--> 302 zipcode_by_state = zipcode_quadtree.point_left_join_polygon(["WKT", "ZCTA5CE10"], ["STUSPS"])
...
File copying.pyx:154, in cudf._lib.copying.gather()
File column.pyx:463, in cudf._lib.column.Column.to_pylibcudf()
File column.pyx:493, in cudf._lib.column.Column.to_pylibcudf()
File types.pyx:284, in cudf._lib.types.dtype_to_pylibcudf_type()
TypeError: data type 'geometry' not understood
I'm guessing that CI didn't catch that because I moved notebook-checking into a bash function in #1407, but didn't add -E here:
cuspatial/ci/test_notebooks.sh
Line 4 in fe3b0c9
Anyway, that failure is not related to the changes in this PR. This close to code freeze, we should merge this PR as-is and fix that in a follow-up.
|
/merge |
3 tasks
|
Thanks all! 🙏 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
The notebook-testing CI job in this repo does not actually cause a loud CI failure if any errors are detected in notebooks. That's because of a `bash` mistake I made in #1407... that PR moved notebook-checking into a function, but didn't add a `set -E` to be sure errors from inside that function were appropriately trapped. This PR fixes that: * ensures that notebook failures actually cause CI failures * fixes 2 typos in `nyc_taxi_years_correlation.ipynb` code - *(not caught in #1422 because of this CI script bug)* Context: #1422 (review) ## Notes for Reviewers ### How I tested this Originally did not skip any notebooks. Saw the failures in one of the notebooks cause an actual merge-blocking CI failure. Build link: https://github.com/rapidsai/cuspatial/actions/runs/10199784404/job/28219162698?pr=1424 # Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - Mark Harris (https://github.com/harrism) - https://github.com/jakirkham URL: #1424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1407 skipped the taxi dropoffs notebook due to performance regression fixed in #1418, so this PR re-enables the notebook in CI by removing it from SKIPNBS in ci/test_noteboks.sh.
Checklist