Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
github-actions
bot
added
conda
jameslamb
commented
Aug 7, 2024
|
CI is in a bad state here, I don't think it's a result of this PR's changes. We'll need to merge rapidsai/devcontainers#377 to fix the devcontainers builds. And then these others to fix other parts of CI:
I'll check back on this after merging those, before putting this up for review. |
|
Reported the test failures in #1433. The changes in this PR are ready for review. |
jameslamb
changed the title
|
Restarting failed CI jobs now that |
jakirkham
approved these changes
Aug 8, 2024
|
/merge |
|
This will be blocked until #1434 is complete |
|
Restarted again now that #1434 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#58.
scikit-build-core==0.10.0was released today (https://github.com/scikit-build/scikit-build-core/releases/tag/v0.10.0), and wheel-building configurations across RAPIDS are incompatible with it.This proposes upgrading to that version and fixing configuration here in a way that:
scikit-build-coreversionminimum-version) thatscikit-build-coreprovides, to reduce the risk of needing to do this again in the future