Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch traceback to native in pytests #1464

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

In cudf & cuml we have observed a ~10% to ~20% respectively speed up of pytest suite execution by switching pytest traceback to --native:

currently:

102474 passed, 2117 skipped, 902 xfailed in 892.16s (0:14:52)

--tb=short:

102474 passed, 2117 skipped, 902 xfailed in 898.99s (0:14:58)

--tb=no:

102474 passed, 2117 skipped, 902 xfailed in 815.98s (0:13:35)

--tb=native:

102474 passed, 2117 skipped, 902 xfailed in 820.92s (0:13:40)

This PR makes similar change to cuspatial repo.

xref: rapidsai/cudf#16851

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 25, 2024
@galipremsagar galipremsagar self-assigned this Sep 25, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner September 25, 2024 15:04
@github-actions github-actions bot added the Python Related to Python code label Sep 25, 2024
Copy link
Contributor

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the same thing in DLFW, good to see we're applying it everywhere

@bdice
Copy link
Contributor

bdice commented Sep 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit d4835ee into rapidsai:branch-24.10 Sep 25, 2024
88 checks passed
@jakirkham
Copy link
Member

A bunch of jobs failed on branch-24.10. They appear to be service issues (so unlikely to be related to the changes here). Have tried restarting them. Though let's keep an eye out in case more issues crop up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants