Have Cython methods accept pylibcudf.Column instead of cudf._lib.column.Column #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
harrism
reviewed
Jan 14, 2025
| @@ -26,7 +26,12 @@ from cuspatial._lib.cpp.types cimport collection_type_id, geometry_type_id | |||
| from cuspatial._lib.types cimport collection_type_py_to_c | |||
|
|
|||
|
|
|||
| cpdef haversine_distance(Column x1, Column y1, Column x2, Column y2): | |||
| cpdef haversine_distance( | |||
| plc_Column x1, | |||
There was a problem hiding this comment.
Can these just be imported as Column?
There was a problem hiding this comment.
We'll have a namespace shadowing issue because we need cudf.core.column.Column (for the output) and pylibcudf.Column (to type these inputs). I decided to alias pylibcudf.Column to plc_Column, but happy to use another alias if you'd like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to rapidsai/cudf#17317, it appears the Cython bindings are not dependent on any methods specifically on
cudf._lib.column.Column. It appears most routines operate oncolumn_viewwhich can be provided by apylibcudf.Column.This PR essentially makes the routines defined in Cython accept a
pylibcudf.Columninstead and return acudf.core.column.Columnobject instead (which should help cudf transition away from itscudf._lib.column.Column)Checklist