Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Pin gdal to be compatible with cuxfilter #245

Merged
merged 4 commits into from
Jun 16, 2020
Merged

[REVIEW] Pin gdal to be compatible with cuxfilter #245

merged 4 commits into from
Jun 16, 2020

Conversation

raydouglass
Copy link
Member

cuxfilter has a dependency on geopandas which seems to be locked to gdal 3.0.x.

@raydouglass raydouglass requested a review from a team as a code owner June 15, 2020 21:14
@raydouglass raydouglass self-assigned this Jun 15, 2020
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@mike-wendt
Copy link
Contributor

rerun tests

@mike-wendt
Copy link
Contributor

mike-wendt commented Jun 15, 2020 •
edited
Loading

Not sure why that pulled gdal 3.1.0 with the spec of >=3.0.2,<3.1.0a - retrying the builds

@mike-wendt
Copy link
Contributor

Not sure why that pulled gdal 3.1.0 with the spec of >=3.0.2,<3.1.0a - retrying the builds
Figure this out, needed to merge rapidsai/integration#53 and rebuild updated env pkgs - this is done now and should pass

@raydouglass
Copy link
Member Author

rerun tests

@mike-wendt
Copy link
Contributor

Should be GTG now with the above commit

@harrism
Copy link
Member

harrism commented Jun 16, 2020

I would like @thomcom to approve before merging.

@harrism harrism requested a review from thomcom June 16, 2020 00:42
@harrism harrism added the 3 - Ready for Review Ready for review by team label Jun 16, 2020
thomcom
thomcom approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@thomcom thomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks lgtm

@thomcom thomcom merged commit de1e443 into rapidsai:branch-0.15 Jun 16, 2020
@weiji14 weiji14 mentioned this pull request Dec 4, 2020
Closed
@weiji14 weiji14 mentioned this pull request Jan 13, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Jan 15, 2021
@weiji14
Pin gdal to 3.1.x(#339)
871c991 
Bump `gdal` from 3.0.x to 3.1.x, fixes #327 and supersedes/reverts #245.

Authors:
  - Wei Ji <weiji.leong@vuw.ac.nz>
  - Keith Kraus <kkraus@nvidia.com>

Approvers:
  - Keith Kraus (@kkraus14)
  - AJ Schmidt (@ajschmidt8)

URL: #339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@mike-wendt mike-wendt mike-wendt approved these changes

@thomcom thomcom thomcom approved these changes

Assignees

@raydouglass raydouglass

Labels
3 - Ready for Review Ready for review by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@raydouglass @GPUtester @mike-wendt @harrism @thomcom @ajschmidt8