Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support spaces in build.sh paths #385

Merged
merged 7 commits into from
Jun 9, 2021
Merged

Support spaces in build.sh paths #385

merged 7 commits into from
Jun 9, 2021

Conversation

jolorunyomi
Copy link
Contributor

Summary

Add support for space in workspace

@jolorunyomi jolorunyomi requested a review from a team as a code owner April 15, 2021 19:44
@github-actions github-actions bot added the gpuCI Related to Continuous Integration / Automation label Apr 15, 2021
ajschmidt8
ajschmidt8 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few stylistic suggestions here to move some terminating quotes to the end of the line, but should be fine either way.

ci/docs/build.sh Outdated Show resolved Hide resolved
ci/docs/build.sh Outdated Show resolved Hide resolved
jolorunyomi and others added 2 commits April 19, 2021 12:17
@jolorunyomi @ajschmidt8
Apply suggestions from code review
bb6153c 
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@jolorunyomi
Merge branch 'branch-0.20' into workspace
a3812f6
@trxcllnt
Copy link
Contributor

rerun tests

trxcllnt
trxcllnt requested changes May 18, 2021
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
@trxcllnt trxcllnt changed the title add support for space in workspace Support spaces in build.sh paths May 18, 2021
@trxcllnt trxcllnt added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 18, 2021
@trxcllnt trxcllnt self-requested a review May 18, 2021 12:38
trxcllnt
trxcllnt reviewed May 18, 2021
View reviewed changes
ci/local/build.sh Outdated Show resolved Hide resolved
@harrism
Copy link
Member

harrism commented May 25, 2021

@jolorunyomi can you respond to @trxcllnt 's review? Thanks.

@jolorunyomi @trxcllnt
Update ci/local/build.sh
ad0fc8b 
Co-authored-by: Paul Taylor <paul.e.taylor@me.com>
@jolorunyomi jolorunyomi requested a review from trxcllnt May 25, 2021 13:13
@trxcllnt
Copy link
Contributor

rerun tests

1 similar comment
@harrism
Copy link
Member

harrism commented May 27, 2021

rerun tests

@harrism harrism added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 27, 2021
ajschmidt8
ajschmidt8 reviewed May 28, 2021
View reviewed changes
ci/cpu/build.sh Outdated Show resolved Hide resolved
@jolorunyomi @ajschmidt8
Update ci/cpu/build.sh
bb36025 
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@ajschmidt8
Copy link
Member

should be good to merge this pending @trxcllnt's re-review

@ajschmidt8 ajschmidt8 changed the base branch from branch-21.06 to branch-21.08 June 8, 2021 22:47
@harrism
Copy link
Member

harrism commented Jun 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 882b235 into branch-21.08 Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge gpuCI Related to Continuous Integration / Automation improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jolorunyomi @trxcllnt @harrism @ajschmidt8