Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cuspatial version for calver, fix CMake FindPackage cudf #401

Merged
merged 4 commits into from
May 18, 2021
Merged

Update cuspatial version for calver, fix CMake FindPackage cudf #401

merged 4 commits into from
May 18, 2021

Conversation

trxcllnt
Copy link
Contributor

  • Update cuspatial version for calver
  • Fix CMake FindPackage(cudf)

@trxcllnt trxcllnt requested a review from a team as a code owner May 18, 2021 13:02
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 18, 2021
@trxcllnt trxcllnt requested review from raydouglass and cwharris May 18, 2021 13:13
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels May 18, 2021
@trxcllnt trxcllnt requested a review from a team as a code owner May 18, 2021 13:43
kkraus14
kkraus14 reviewed May 18, 2021
View reviewed changes
conda/environments/cuspatial_dev_cuda11.1.yml
@@ -7,11 +7,11 @@ channels:
dependencies:
- clang=8.0.1
- clang-tools=8.0.1
- cudf=0.20.*
- cudf=21.06.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually build / support CUDA 11.1, so we may want to drop this file altogether?

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 18, 2021
@kkraus14
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e0ee443 into rapidsai:branch-21.06 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@raydouglass raydouglass raydouglass approved these changes

@cwharris cwharris Awaiting requested review from cwharris

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trxcllnt @kkraus14 @raydouglass