-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using public cudf testing utilities #431
Switch to using public cudf testing utilities #431
Conversation
@vyasr can we get this finished for 21.08? If not, please retarget to 21.10. |
@harrism sure if you think it's worthwhile I can prioritize getting this done now, it shouldn't be too hard but just didn't seem to be a priority. |
Is cuSpatial testing broken without this PR? If not, it can wait until 21.10. |
Testing isn't broken, it's just using some cudf functions that are not intended to be part of the API. We don't want cudf to have to maintain API stability for those functions since they're internal, so we need to remove their usage from here. I know this affects (at minimum) cugraph as well. Since we control these functions in cudf we can avoid making any breaking changes until other downstream packages stop using them, though, so I don't think this is urgent for this release. That said, I've started trying to resolve these conflicts, so I can update here if finishing this for 21.08 will be feasible. |
…eq from test_from_geopandas.
0940223
to
024f819
Compare
@harrism I think this PR should be good to go if tests pass. |
rerun tests |
@gpucibot merge |
As of rapidsai/cudf#7495 the
cudf.tests.utils
module (and in particular theassert_eq
function) are no longer part of the public API. This PR switches tests to use the public testing functions in thecudf.testing
subpackage.This PR is currently blocked by #430 and rapidsai/cudf#8646.