Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cython Table APIs to match changes in cudf. #449

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Update Cython Table APIs to match changes in cudf. #449

merged 2 commits into from
Sep 17, 2021

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 14, 2021

This makes cuspatial compatible with the changes in rapidsai/cudf#9199.

@vyasr vyasr added cuDF 3 - Ready for Review Ready for review by team Cython improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 14, 2021
@vyasr vyasr requested a review from a team as a code owner September 14, 2021 17:02
@vyasr vyasr self-assigned this Sep 14, 2021
@github-actions github-actions bot added the Python Related to Python code label Sep 14, 2021
@vyasr vyasr mentioned this pull request Sep 14, 2021
Merged
@vyasr vyasr added the 0 - Blocked Cannot progress due to external reasons label Sep 14, 2021
@vyasr
Copy link
Contributor Author

vyasr commented Sep 14, 2021

This should not be merged until after the rapidsai/cudf#9199.

@vyasr
Copy link
Contributor Author

vyasr commented Sep 15, 2021

rerun tests

1 similar comment
@vyasr
Copy link
Contributor Author

vyasr commented Sep 16, 2021

rerun tests

@ajschmidt8 ajschmidt8 mentioned this pull request Sep 17, 2021
Merged
@jakirkham
Copy link
Member

rerun tests

@jakirkham jakirkham mentioned this pull request Sep 17, 2021
Open
@vyasr vyasr removed the 0 - Blocked Cannot progress due to external reasons label Sep 17, 2021
thomcom
thomcom approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@thomcom thomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vyasr
Copy link
Contributor Author

vyasr commented Sep 17, 2021 •
edited
Loading

It looks like we also need to update cuspatial for rapidsai/cudf#9011. I'll lump those changes into this PR as well.

@vyasr
Copy link
Contributor Author

vyasr commented Sep 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7c2ed1d into rapidsai:branch-21.10 Sep 17, 2021
@jakirkham
Copy link
Member

Thank you Vyas! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team cuDF Cython improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @jakirkham @thomcom