Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build cuspatial with scikit-build #524

Merged
merged 16 commits into from
May 20, 2022
Merged

Build cuspatial with scikit-build #524

merged 16 commits into from
May 20, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 11, 2022 •
edited
Loading

This PR switches cuspatial's Python build system to use scikit-build and CMake.

@vyasr vyasr added 3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration non-breaking Non-breaking change labels May 11, 2022
@vyasr vyasr self-assigned this May 11, 2022
@github-actions github-actions bot added conda Related to conda and conda configuration gpuCI Related to Continuous Integration / Automation Python Related to Python code labels May 11, 2022
@vyasr vyasr added improvement Improvement / enhancement to an existing function and removed conda Related to conda and conda configuration gpuCI Related to Continuous Integration / Automation Python Related to Python code labels May 11, 2022
@github-actions github-actions bot added conda Related to conda and conda configuration gpuCI Related to Continuous Integration / Automation Python Related to Python code libcuspatial Relates to the cuSpatial C++ library labels May 12, 2022
@vyasr vyasr marked this pull request as ready for review May 13, 2022 19:42
@vyasr vyasr requested review from a team as code owners May 13, 2022 19:42
@vyasr
Copy link
Contributor Author

vyasr commented May 13, 2022

This PR depends on rapidsai/rapids-cmake#189, but once that's merged I think we should be good to go here.

@vyasr vyasr force-pushed the feature/skbuild branch 2 times, most recently from 50d9b13 to 627cdbd Compare May 16, 2022 22:30
@github-actions github-actions bot removed the libcuspatial Relates to the cuSpatial C++ library label May 16, 2022
@vyasr vyasr force-pushed the feature/skbuild branch from 627cdbd to 4b3fcba Compare May 17, 2022 02:27
@github-actions github-actions bot added libcuspatial Relates to the cuSpatial C++ library and removed libcuspatial Relates to the cuSpatial C++ library labels May 17, 2022
@vyasr vyasr force-pushed the feature/skbuild branch from 2b39bff to 2db0802 Compare May 17, 2022 05:55
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label May 17, 2022
@github-actions github-actions bot removed the libcuspatial Relates to the cuSpatial C++ library label May 17, 2022
@vyasr
Copy link
Contributor Author

vyasr commented May 17, 2022

rerun tests

harrism
harrism approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vyasr !

@vyasr
Copy link
Contributor Author

vyasr commented May 20, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 47ba833 into rapidsai:branch-22.06 May 20, 2022
@vyasr vyasr deleted the feature/skbuild branch May 23, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@harrism harrism harrism approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration conda Related to conda and conda configuration gpuCI Related to Continuous Integration / Automation improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @harrism @ajschmidt8