Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor linestring_distance to header only API #526

Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
50146a8
Initial conversion, passes compilation and test
isVoid May 12, 2022
1861dc9
Add docstring
isVoid May 13, 2022
0d5dc94
Add RAI specification
isVoid May 13, 2022
ca54b2c
add default stream parameter
isVoid May 13, 2022
a427af6
Add first test and cast references around.
isVoid May 13, 2022
2c6ec85
Add more tests
isVoid May 13, 2022
9958f48
fix offset arrays
isVoid May 16, 2022
dc944c5
fix wrong gtest binary name
isVoid May 16, 2022
e36186a
Add precommit hooks and script for cmake format/lint
isVoid May 16, 2022
62aa1ad
update with optimized code
isVoid May 17, 2022
af38652
remove dependency on cudf atomics
isVoid May 17, 2022
ae11443
regroup includes
isVoid May 17, 2022
79d57aa
Use size_t as index type.
isVoid May 18, 2022
e2a3db7
some fixes on tests
isVoid May 18, 2022
a1512d8
Revert cmake-format and precommit hooks
isVoid May 18, 2022
9b1687c
Remove `Cart2dA` and `Cart2dB`
isVoid May 18, 2022
dea41f1
Documentation update
isVoid May 18, 2022
270cfe2
Style fix
isVoid May 18, 2022
cb5d301
fix broken compile
isVoid May 19, 2022
183c10c
Removes `device_atomics` usage
isVoid May 19, 2022
b2fbaad
Add `internal` marker to internal docstrings.
isVoid May 19, 2022
1752485
Move derived traits to traits.hpp
isVoid May 19, 2022
fe83ea2
add back raw_reference_cast
isVoid May 19, 2022
7ee9b94
Revert "Removes `device_atomics` usage"
isVoid May 25, 2022
5926bcc
add atomicMax
isVoid May 25, 2022
8194142
Address atomic operation review
isVoid May 25, 2022
4a81a5b
style
isVoid May 25, 2022
0309fd9
Revert "Address atomic operation review"
isVoid May 25, 2022
ce6280f
address device atomics reviews
isVoid May 25, 2022
2c5e8bf
inline `addr` dereference
isVoid May 25, 2022
80fceba
Reverting attempts to cast to `ll`, not `ull`
isVoid May 25, 2022
d849ce3
Add mutable requirement for OutputIterator
harrism May 26, 2022
e8fe80b
Merge branch 'branch-22.06' into feature/header_only_linestring_distance
harrism Jun 1, 2022
d441462
Document atomics
harrism Jun 1, 2022
9a15132
Remove erroneous nested std::vector
harrism Jun 1, 2022
d242701
Responds to review feedback
harrism Jun 1, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add mutable requirement for OutputIterator
harrism authored May 26, 2022
commit d849ce34331e5057bd84b9373ba5105ba63c4bea
Original file line number Diff line number Diff line change
@@ -145,7 +145,7 @@ T __device__ squared_segment_distance(vec_2d<T> const& a,
* @tparam OffsetIterator Iterator to linestring offsets. Must meet requirements of
* [LegacyRandomAccessIterator][LinkLRAI] and be device-accessible.
* @tparam OutputIterator Iterator to output distances. Must meet requirements of
* [LegacyRandomAccessIterator][LinkLRAI] and be device-accessible.
* [LegacyRandomAccessIterator][LinkLRAI] and be device-accessible and mutable.
*
* @param[in] linestring1_offsets_begin Iterator to the begin of the range of linestring offsets
* in pair 1.