Pairwise Point to Point Distance; Rename Folder distances to distance
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mark Harris <mharris@nvidia.com>
…into feature/point_distance
…into feature/point_distance
isVoid
changed the title
distances to distance
isVoid
changed the title
distances to distancedistances to distance
robertmaynard
approved these changes
Jul 28, 2022
harrism
requested changes
Jul 28, 2022
Comment on lines
+39
to
+46
| static_assert( | ||
| detail::is_floating_point<T, | ||
| typename std::iterator_traits<Cart2dItB>::value_type::value_type, | ||
| typename std::iterator_traits<OutputIt>::value_type>(), | ||
| "Inputs and output must be floating point types."); | ||
|
|
||
| static_assert(detail::is_same<T, typename std::iterator_traits<OutputIt>::value_type>(), | ||
| "Inputs and output must be the same types."); |
There was a problem hiding this comment.
If we merge #579 you can replace this with is_same_floating_point.
harrism
added
breaking
|
Also need to update paths in Cython files to fix the build. |
|
Our cython file org fell out of sync with cpp file org. So in this PR I also moved them into |
harrism
approved these changes
Jul 29, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements 2D point-point L2 distance. Also renamed folder
distancesintodistanceContributes to #231