Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Point Linestring Distance #573
Add Point Linestring Distance #573
Changes from all commits
de78310
6011900
9761eab
2ed60eb
e3ec12d
a72ac10
31b1e78
f55af2f
e874f3b
e9b2ca8
f2277f0
7bc0914
a8ec5ff
1fdfd59
0274875
df286a0
688fbb5
d0c0c4f
1c4ad61
e4038a5
5004bbe
986dbb2
2feab4b
5e07194
4834aa2
de0feb7
c897974
6dc34e0
624a97f
b65d9b2
c57cad6
e2235b0
45787e8
f1da463
b5aca2d
b88a7bb
b3e7fd7
bd1f62b
cb27513
e2d4f9c
6ac10a7
ecbfc2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs aren't the same as the ones in
detail/point_linestring_distance.cuh
, but they are close. I slightly prefer the ones in detail. I don't like seeing the duplication, is there a good solution to it? They'll diverge and need constant attention.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use
@copydoc
to copy all documentation contents from one to other. But I haven't tested if we can override specifics secions/parameters after doing that. Will try it out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add docs (e.g. additional @param) after @copydoc, but you can't remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want different doc contents for the internal function v.s. the user API? IMO the internal function doc should describe how the function works to help developer understand the logics, and user API docs should focus on usage, parameter constraints, exceptions etc..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, having started this conversation, I prefer a single doc. Everything being developed in C++ RAPIDS,
detail
,experimental
, and public namespaces, is targeted at power users aka advanced developers. I don't see much of a distinction between developer and user. Plus maintenance is much more complicated to maintain parallel docsets that are almost the same but differ in obscure ways. I'm not dogmatic about this though, if you think more refined documentation is appropriate I won't stop you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, since the internal function will not be rendered on doxygen website,
@copydoc
will essentailly have no effect. Eventually the function's docstring goes with the function it decorates. While reducing duplication is a good thing, keeping track of remote referencing could be even a harder task to maintain without the help of doxygen.