Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Improve documentation and return a hausdorff matrix. #58

Merged
merged 14 commits into from
Oct 9, 2019

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented Sep 12, 2019

Write an example that explains what Hausdorff distance is. Correct the return value of this function. Fixes #40

@thomcom thomcom requested a review from a team as a code owner September 12, 2019 21:01
@thomcom thomcom changed the title Improve documentation and return a hausdorff matrix. [REVIEW] Improve documentation and return a hausdorff matrix. Sep 23, 2019
Copy link
Contributor

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but print statement should likely be removed.

Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs suggestions.

python/cuspatial/cuspatial/core/gis.py Outdated Show resolved Hide resolved
python/cuspatial/cuspatial/core/gis.py Outdated Show resolved Hide resolved
python/cuspatial/cuspatial/core/gis.py Show resolved Hide resolved
python/cuspatial/cuspatial/core/gis.py Outdated Show resolved Hide resolved
@thomcom
Copy link
Contributor Author

thomcom commented Oct 1, 2019

Ready to go again pending CI

Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor change.

python/cuspatial/cuspatial/core/gis.py Outdated Show resolved Hide resolved
@thomcom thomcom requested a review from harrism October 8, 2019 22:06
@thomcom thomcom merged commit 8be099d into rapidsai:branch-0.10 Oct 9, 2019
@thomcom thomcom deleted the bug-ext-hausdorff-dataframe branch July 29, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cuspatial.directed_hausdorff_distance does not return a DataFrame
3 participants