Introduce multilinestring_range structure, simplifies point-linestring distance API
#747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/multipoint_array
Co-authored-by: H. Thomson Comer <thomcom@gmail.com>
…l into feature/multipoint_array
…into feature/multilinestring_array
isVoid
commented
Oct 20, 2022
Comment on lines
+104
to
+105
| return multipoint_ref<VecIterator>{_points_begin + _geometry_begin[idx], | ||
| _points_begin + _geometry_begin[idx + 1]}; |
There was a problem hiding this comment.
I had to revert this change in #731 because I need to use this method in device code. The previous proposal requires creating a transform iterator and dereference it. Not all code path is available on device and is expensive.
3 tasks
harrism
requested changes
Oct 26, 2022
cpp/include/cuspatial/experimental/detail/point_linestring_distance.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/detail/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/point_linestring_distance.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/point_linestring_distance.cuh
Outdated
Show resolved
Hide resolved
harrism
approved these changes
Oct 27, 2022
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
…e.cuh Co-authored-by: Mark Harris <mharris@nvidia.com>
thomcom
requested changes
Oct 27, 2022
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
thomcom
approved these changes
Oct 28, 2022
|
Approvin |
isVoid
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #731 , this PR introduces a new range object named
multilinestring_rangeand simplifies the point-linestring distance API. Closes #705 .Checklist