Add reset_index to GeoSeries and GeoDataFrame
#856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcom
added
bug
3 tasks
isVoid
reviewed
Dec 14, 2022
| if not drop and inplace: | ||
| pytest.skip( | ||
| "For exception checks, see " | ||
| "test_reset_index_dup_level_name_exceptions" |
There was a problem hiding this comment.
Is this just a left over from cudf?
There was a problem hiding this comment.
It is copied over from cudf, yes. I could rewrite the parameterizations so that this invalid case never occurs. If drop == False and inplace == True for a series reset_index an exception is thrown. Since the result has to be a GeoDataFrame, inplace is impossible. cudf just built a matrix of parameterizations and skips the impossible ones.
There was a problem hiding this comment.
I see, if it's expected to fail, instead of skipping, should we just wrap it in pytest.raises block?
thomcom
requested review from
harrism and
isVoid
and removed request for
vyasr
thomcom
added
4 - Needs Reviewer
isVoid
approved these changes
Dec 15, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #849
Description
This PR adds
.reset_indextoGeoSeriesandGeoDataFrame. It testsGeoDataFrameto the same level thatcudftests the method. HoweverGeoSerieshas four blocks of parameterized tests numbering in the hundreds. I only implement the first test block forGeoSeries.Checklist