-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple bugs in user guide #906
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.04 #906 +/- ##
===============================================
Coverage ? 92.49%
===============================================
Files ? 25
Lines ? 1039
Branches ? 0
===============================================
Hits ? 961
Misses ? 78
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'm somewhat concerned by the substantial changes that this update made to the various notebooks, wouldn't we think that at least in the ordered cases the outputs would not change? |
@@ -133,7 +133,8 @@ | |||
"import cudf\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is a change that was made at the shapely level? I'm not familiar with seeing the polygon points when printing a shapely object.
Reply via ReviewNB
@@ -133,7 +133,8 @@ | |||
"import cudf\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see why these values changed. Perhaps we should set a random seed in the notebook to prevent this from happening as much?
Reply via ReviewNB
|
I merged 23.04 in via the web interface, will merge when tests complete. |
/merge |
Description
This PR closes #902 and closes #901, fixes
pairwise_linestring_distance
cell usage bug and fixes a bug in PiP cell.Checklist