Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple bugs in user guide #906

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Feb 7, 2023

Description

This PR closes #902 and closes #901, fixes pairwise_linestring_distance cell usage bug and fixes a bug in PiP cell.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@isVoid isVoid added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Feb 7, 2023
@isVoid isVoid self-assigned this Feb 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@5cec7a9). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04     #906   +/-   ##
===============================================
  Coverage                ?   92.49%           
===============================================
  Files                   ?       25           
  Lines                   ?     1039           
  Branches                ?        0           
===============================================
  Hits                    ?      961           
  Misses                  ?       78           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thomcom
Copy link
Contributor

thomcom commented Feb 8, 2023

I'm somewhat concerned by the substantial changes that this update made to the various notebooks, wouldn't we think that at least in the ordered cases the outputs would not change?

@@ -133,7 +133,8 @@
"import cudf\n",
Copy link
Contributor

@thomcom thomcom Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is a change that was made at the shapely level? I'm not familiar with seeing the polygon points when printing a shapely object.


Reply via ReviewNB

@@ -133,7 +133,8 @@
"import cudf\n",
Copy link
Contributor

@thomcom thomcom Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see why these values changed. Perhaps we should set a random seed in the notebook to prevent this from happening as much?


Reply via ReviewNB

@thomcom
Copy link
Contributor

thomcom commented Feb 8, 2023

ReviewNB worked well this time. Approved.

@thomcom
Copy link
Contributor

thomcom commented Feb 8, 2023

I merged 23.04 in via the web interface, will merge when tests complete.

@thomcom
Copy link
Contributor

thomcom commented Feb 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit bcf45ef into rapidsai:branch-23.04 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
4 participants