Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors bounding.py to accept GeoSeries Input #934

Merged
merged 28 commits into from
Feb 23, 2023
Merged

Refactors bounding.py to accept GeoSeries Input #934

merged 28 commits into from
Feb 23, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Feb 15, 2023 •
edited
Loading

Description

This PR refactors [polygon|linestring]_bounding_boxes API to accept geoseries input.
closes #929 closes #930

depends on #928

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner February 15, 2023 18:03
@isVoid isVoid requested a review from cwharris February 15, 2023 18:03
@github-actions github-actions bot added the Python Related to Python code label Feb 15, 2023
@isVoid isVoid requested review from thomcom and harrism and removed request for cwharris February 15, 2023 18:04
@isVoid isVoid self-assigned this Feb 15, 2023
@isVoid isVoid added breaking Breaking change feature request New feature or request improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team and removed feature request New feature or request labels Feb 15, 2023
@isVoid
Copy link
Contributor Author

isVoid commented Feb 15, 2023

I have also decided to work on the user guide notebook as a finishing item after I finished working on all the geoseries refactor due to the large git diff every time I work on one.

@isVoid isVoid mentioned this pull request Feb 15, 2023
Closed
harrism
harrism approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the users.ipynb need to be updated for all these API changing PRs? Otherwise looks good.

@isVoid
Copy link
Contributor Author

isVoid commented Feb 22, 2023

Does the users.ipynb need to be updated for all these API changing PRs? Otherwise looks good.

Yes, decided to do that as a separate effort, tracked by #935

@isVoid
Copy link
Contributor Author

isVoid commented Feb 23, 2023

/merge

@rapids-bot rapids-bot bot merged commit 62b61dc into rapidsai:branch-23.04 Feb 23, 2023
@mroeschke mroeschke mentioned this pull request Aug 28, 2024
Merged
3 tasks
@mroeschke mroeschke mentioned this pull request Nov 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@thomcom thomcom thomcom approved these changes

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
3 participants
@isVoid @thomcom @harrism