-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC]: Move build instructions to dev guide #999
Merged
rapids-bot
merged 8 commits into
rapidsai:branch-23.04
from
jarmak-nv:Build-From-Source-To-Docs
Mar 20, 2023
Merged
[DOC]: Move build instructions to dev guide #999
rapids-bot
merged 8 commits into
rapidsai:branch-23.04
from
jarmak-nv:Build-From-Source-To-Docs
Mar 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
thomcom
approved these changes
Mar 17, 2023
isVoid
reviewed
Mar 17, 2023
Allows for future expansion/growth of build guide.
isVoid
reviewed
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. Can you also add an item in the toctree of developer_guide/index.md
, build
?
Added |
isVoid
approved these changes
Mar 20, 2023
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
Closes #908 With all of the development on cuSpatial, it's time for a new README that is both more up-to-date, and more aligned with other RAPIDS READMEs. ### Outstanding tasks - [x] Add function hyperlinks - [x] Move `build from source` instructions to developer docs - [x] Remove from readme - [x] #999 - [x] Consider adding visuals for things like distances using [GitHub topojson](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-diagrams#creating-geojson-and-topojson-maps) - [x] #987 Authors: - Ben Jarmak (https://github.com/jarmak-nv) Approvers: - H. Thomson Comer (https://github.com/thomcom) - Mark Harris (https://github.com/harrism) - Michael Wang (https://github.com/isVoid) URL: #977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #908 and unblocks #977
This PR moves the existing build from source instructions to the developer docs page. It does not make any changes to the instructions.
Checklist