Reduce cagra build binary size #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfeher
added
improvement
|
Currently we have around 13 MiB reduction in |
achirkin
reviewed
Sep 27, 2024
| @@ -357,8 +353,7 @@ void build_knn_graph( | |||
| raft::host_matrix_view<IdxT, int64_t, raft::row_major> knn_graph, | |||
| cuvs::neighbors::nn_descent::index_params build_params) | |||
| { | |||
| auto nn_descent_idx = cuvs::neighbors::nn_descent::index<IdxT>(res, knn_graph); | |||
| cuvs::neighbors::nn_descent::build<DataT, IdxT>(res, build_params, dataset, nn_descent_idx); | |||
| auto nn_descent_idx = cuvs::neighbors::nn_descent::build(res, build_params, dataset); | |||
There was a problem hiding this comment.
This is relevant: #264 (comment)
|
Most of these changes were already contained in #264. We keep this open to test further improvements in build binary size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
cagra::buildwe use eitherivf_pqornn_descent. Until now we used these algorithm through thedetailnamespace, which resulted in recompilation. This PR changes to the public interface ofivf_pqandnn_descentto avoid recompilation.