fix test failing on non-matching indices for newer dask version #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
approved these changes
Sep 6, 2022
exactlyallan
approved these changes
Sep 6, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading to dask 22.9.0, this test was failing as a result of a dask_dataframe compute() call resulting in a cuDF dataframe with incorrect indices (keeps partitioned indices after
map_partitionscall).This does not affect the behavior of graph charts in cuxfilter, so a trivial fix to the test, which compares against a result dataframe with sequential indices, is enough to resolve the issue.
cc @galipremsagar