Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates and fixes #463

Merged
merged 16 commits into from
Apr 4, 2023
Merged

Updates and fixes #463

merged 16 commits into from
Apr 4, 2023

Conversation

AjayThorve
Copy link
Member

@AjayThorve AjayThorve commented Apr 4, 2023 •
edited
Loading

This PR aims majorly at resolving the following issues:

  • box-select not working wasn't working with the latest holoviews - fixed
  • update breaking changes to cuspatial api for point_in_polygon
  • Gird layout issue when using d.app() - fixed by using panel.GridSpec instead of panel.GridStack(external library)
  • Using panel.ReactTemple instead of custom implementation - better to maintain, and reuse a better implementation
  • Update holoviews version dependency
  • Callback issue when running in web-app mode for bokeh charts, using add_next_tick_callback to resolve this

Tested all notebooks and dashboards locally with cudf and dask_cudf dataframes.
cc @exactlyallan

@AjayThorve AjayThorve requested review from a team as code owners April 4, 2023 02:55
@AjayThorve AjayThorve added non-breaking Non-breaking change bug Something isn't working labels Apr 4, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ajschmidt8
ajschmidt8 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@AjayThorve
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 946eb13 into rapidsai:branch-23.04 Apr 4, 2023
@AjayThorve AjayThorve deleted the fix/box-select-not-working branch April 4, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@exactlyallan exactlyallan exactlyallan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working conda non-breaking Non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AjayThorve @ajschmidt8 @exactlyallan