Dropping Python 3.8 #469
Merged
Dropping Python 3.8 #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
added
improvement
ajschmidt8
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
suprisingly this PR passed CI despite the its upstream RAPIDS dependencies not having published packages for 23.06 3.9. It looks like it's picking up old stable 3.9 packages from 22.12.
Seems like we should probably adjust our nightly workflows to remove the stable Anaconda.org channels for nightly/PR workflows.
that'll be a discussion for another day.
|
@ajschmidt8 can we merge this in that case? |
|
@exactlyallan @AjayThorve could we get a Python review here, and a merge when ready? Thank you! |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops Python 3.8 in favor of 3.9.