-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Numba 0.57.0+ & NumPy 1.21.0+ #480
Conversation
Could someone please add the "improvement" & "non-breaking" labels? |
@AjayThorve Is there an upstream bug in holoviews / numpy that we can link to in that PR so that we know when this limitation is lifted? This is important to track for all of RAPIDS, because |
Hey @bdice, so this issue is already fixed in datashader (holoviz/datashader#1176), although it's not yet part of any release(the latest released datashader version is 0.14.4, and this PR is part of the 0.14.5 milestone). How do you suggest we proceed in this scenario? |
Can we raise an issue on their repo requesting a release (and link that issue here)? |
Have asked for an ETA for release here (https://discourse.holoviz.org/t/module-numpy-has-no-attribute-warnings/5402) |
We have released datashader 1.15, and are working on adding it to conda-forge here. So hopefully you will soon be unblocked. |
Conda-forge datashader-feedstock v0.15.0 PR has been merged so you should be able to proceed shortly. |
Thanks all! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs to sync with / update dependencies.yaml.
thanks everyone, #479 should fix the CI issues, and this PR should be good to merge after that |
@jakirkham can you rebase with |
Toggling for CI |
Align with the rest of RAPIDS on these requirements. Also needed for CUDA 12 support.
As NumPy is used internally, list it as an explicit requirement instead of relying on other dependencies to pull it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update dependencies.yaml
to align. We need numpy
and numba
pinnings and to make the run
section align with the conda list of run dependencies:
Lines 107 to 128 in 472f839
run: | |
common: | |
- output_types: [conda, requirements] | |
packages: | |
- bokeh>=2.4.2,<=2.5 | |
- datashader>=0.15 | |
- geopandas>=0.11.0 | |
- holoviews>=1.15.0,<=1.15.4 | |
- jupyter-server-proxy | |
- libwebp | |
- nodejs>=14 | |
- packaging | |
- panel >=0.14.0,<=0.14.1 | |
- pydeck>=0.3,<=0.5.0 | |
- pyppeteer>=0.2.6 | |
- pyproj>=2.4,<=3.4 | |
- output_types: conda | |
packages: | |
- cudf=23.06 | |
- cuspatial=23.06 | |
- dask-cuda=23.06 | |
- dask-cudf=23.06 |
(requested changes previously: #480 (review))
@bdice, I pushed the requested changes |
/merge |
Thanks all! 🙏 |
Align with the rest of RAPIDS on these requirements. Also needed for CUDA 12 support.