Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect xy-coordinate issue in graphs #487

Merged
merged 5 commits into from
Jun 6, 2023
Merged

fix incorrect xy-coordinate issue in graphs #487

merged 5 commits into from
Jun 6, 2023
+37 −19

Conversation

AjayThorve
Copy link
Member

This PR fixes the issue with graph chart for rendering edges, where if coordinates were not named x and y, generating the chart would throw an error. This was due to hard-coded values xy set as coordinates graph's generate_chart function.

@AjayThorve AjayThorve requested a review from a team as a code owner June 2, 2023 20:59
@github-actions github-actions bot added the Python label Jun 2, 2023
@AjayThorve AjayThorve added non-breaking Non-breaking change bug Something isn't working labels Jun 2, 2023
@AjayThorve
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 43d0f77 into rapidsai:branch-23.08 Jun 6, 2023
@AjayThorve AjayThorve deleted the fix/graph-coordinate-issue branch June 6, 2023 16:45
@exactlyallan exactlyallan mentioned this pull request Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exactlyallan exactlyallan exactlyallan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AjayThorve @exactlyallan