Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor CUDA versions in dependencies.yaml #562

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#7.

Proposes splitting the cuda-version dependency in dependencies.yaml out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

Benefits of this change

  • prevents accidental inclusion of multiple cuda-version version in environments
  • reduces update effort (via enabling more use of globs like "12.*")
  • improves the chance that errors like "conda recipe is missing a dependency" are caught in CI

dependencies.yaml Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@jameslamb jameslamb requested a review from bdice January 11, 2024 15:58
@jameslamb
Copy link
Member Author

1 build, conda-python-tests / tests (11.4.3, centos7, amd64, 3.9, v100, earliest), is failing with stuff like this

INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/opt/conda/envs/test/lib/python3.9/site-packages/xdist/workermanage.py", line 386, in process_from_remote
INTERNALERROR>     warning_message = unserialize_warning_message(
...
INTERNALERROR>   File "/opt/conda/envs/test/lib/python3.9/asyncio/events.py", line 642, in get_event_loop
INTERNALERROR>     raise RuntimeError('There is no current event loop in thread %r.'
INTERNALERROR> RuntimeError: There is no current event loop in thread 'Dummy-8'.

(build link)

Not sure if it's relevant, but that is the only job in the matrix testing with an older driver.

I tried adding the CTK back to the environment for that job: 9ce9fc8.

Let's see if it helps.

@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2024
@jameslamb jameslamb requested a review from a team as a code owner January 11, 2024 18:54
@jameslamb
Copy link
Member Author

From discussion offline with @AjayThorve ... I just pushed 84ce513 putting a ceiling on panel.

I did this in the bluntest way possible (applying it to all conda envs and pyproject.toml) just to test if it fixes the problem, but that might not be ideal. I'm especially skeptical of the pyproject.toml change... if that makes it out into wheels that users install, having a ceiling on panel is going to be disruptive.

If this works, I'm planning to remove that ceiling from pyproject.toml, do you agree @AjayThorve ?

@AjayThorve
Copy link
Member

If this works, I'm planning to remove that ceiling from pyproject.toml, do you agree @AjayThorve ?

Yeah if this works, there haven't been any issues with other envs, and seems like the issue is running parallet pytests with updated panel is causing it. In that case, all we need to do is remove the current upper pin for panel from run dependencies and add a specific panel dependency with >=1.0,<1.3.4 to test_python section (under just conda)

@AjayThorve
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit cd5abc3 into rapidsai:branch-24.02 Jan 11, 2024
28 checks passed
@jameslamb jameslamb deleted the rework-dependencies branch January 11, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants