Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready for Review] Pandas 2.0 compatibility #569

Merged
merged 9 commits into from
Feb 9, 2024
Merged

[Ready for Review] Pandas 2.0 compatibility #569

merged 9 commits into from
Feb 9, 2024

Conversation

AjayThorve
Copy link
Member

@AjayThorve AjayThorve commented Feb 8, 2024 •
edited
Loading

fixes #512

@AjayThorve AjayThorve requested review from a team as code owners February 8, 2024 18:08
@AjayThorve AjayThorve added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function bug Something isn't working and removed improvement Improvement / enhancement to an existing function labels Feb 8, 2024
@jakirkham
Copy link
Member

Thanks Ajay! 🙏

Could you please add "Fixes #512" to the OP?

@jakirkham jakirkham mentioned this pull request Feb 8, 2024
Closed
@AjayThorve AjayThorve changed the title [WIP] Pandas 2.0 compatibility [Ready for Review] Pandas 2.0 compatibility Feb 9, 2024
@AjayThorve AjayThorve added the 3 - Ready for Review Ready for review by team label Feb 9, 2024
galipremsagar
galipremsagar approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, one minor comment.

python/cuxfilter/charts/deckgl/bindings/panel_deck.py Show resolved Hide resolved
@AjayThorve
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit bb275b2 into rapidsai:branch-24.04 Feb 9, 2024
28 checks passed
@jakirkham
Copy link
Member

Thanks Ajay and Prem! 🙏

@AjayThorve AjayThorve deleted the pandas-upgrade branch February 9, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@exactlyallan exactlyallan exactlyallan approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working conda non-breaking Non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check compatability with cuDF pandas 2.0 migration
5 participants
@AjayThorve @jakirkham @exactlyallan @galipremsagar @AyodeAwe