Skip to content

Commit

Permalink
Ensure tests run for Python 3.10 (#1080)
Browse files Browse the repository at this point in the history
Previously we had disabled `cucim` testing for Python `3.10` because the tests depended on `3.10` packages of `cudf`, which weren't previously available.

Now that `3.10` packages of `cudf` are available, we can enable `3.10` testing for `cucim`.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Jordan Jacobelli (https://github.com/Ethyling)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #1080
  • Loading branch information
ajschmidt8 authored Jan 18, 2023
1 parent c034d22 commit 2c88933
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@ jobs:
conda-python-tests:
needs: conda-python-build
secrets: inherit
# TODO: Switch this testing branch to "cuda-118" after `cudf` `3.10` builds are out.
# There is a circular testing dependency between `dask-cuda` and `cudf` right now, which
# prevents us from running `3.10` tests for `dask-cuda` until `3.10` `cudf` packages are published.
uses: rapidsai/shared-action-workflows/.github/workflows/conda-python-tests.yaml@main
uses: rapidsai/shared-action-workflows/.github/workflows/conda-python-tests.yaml@cuda-118
with:
build_type: pull-request
wheel-build:
Expand Down
1 change: 1 addition & 0 deletions ci/release/update-version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ sed_runner "s/export UCXPY_VERSION=.*/export UCXPY_VERSION="${NEXT_UCXPY_VERSION
# Bump cudf and dask-cudf testing dependencies
sed_runner "s/cudf=.*/cudf=${NEXT_SHORT_TAG}/g" dependencies.yaml
sed_runner "s/dask-cudf=.*/dask-cudf=${NEXT_SHORT_TAG}/g" dependencies.yaml
sed_runner "s/cucim=.*/cucim=${NEXT_SHORT_TAG}/g" dependencies.yaml
sed_runner "s/ucx-py=.*/ucx-py=${NEXT_UCXPY_VERSION}/g" dependencies.yaml
2 changes: 1 addition & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ dependencies:
common:
- output_types: [conda]
packages:
- cucim
- cucim=23.02
- cudf=23.02
- dask-cudf=23.02
- pytest
Expand Down

0 comments on commit 2c88933

Please sign in to comment.